Disable timing tests for both Docker and macOS builds #1325
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1325 +/- ##
==========================================
+ Coverage 88.37% 88.67% +0.30%
==========================================
Files 316 321 +5
Lines 28440 28508 +68
Branches 3138 3138
==========================================
+ Hits 25133 25280 +147
+ Misses 2168 2091 -77
+ Partials 1139 1137 -2 ☔ View full report in Codecov by Sentry. |
test/CancellationHandleTest.cpp
Outdated
| @@ -153,7 +153,7 @@ TEST(CancellationHandle, ensureObjectLifetimeIsValidWithoutWatchDogStarted) { | |||
| namespace ad_utility { | |||
|
|
|||
| TEST(CancellationHandle, verifyWatchDogDoesChangeState) { | |||
| #ifdef __APPLE__ | |||
| #if (defined(__APPLE__)) || defined(_QLEVER_NO_TIMING_TESTS) | |||
There was a problem hiding this comment.
To be honest, I would simply rely on the custom macro and just set the flag for macos builds. In my opinion this makes more sense as it allows people on actual macs (outside of GH action runners) to run the tests normally
There was a problem hiding this comment.
Thanks for the feedback.
I have incorporated it, let's see if this works.
hannahbast
changed the title
Signed-off-by: Johannes Kalmbach <[email protected]>
hannahbast
changed the title
|
The Docker build that performs ARM-64 cross compilation has unreliable timing when run as part of a GitHub workflow. We therefore now disable timing tests not only for the macOS build (like before), but also for the Docker builds. That way the publication of Docker images is not prevented by spuriously failing timing tests anymore.